[plugins] Pass remote IDs through request_plugin_install - #31713
Closed
adaley-openai wants to merge 1 commit into
Closed
[plugins] Pass remote IDs through request_plugin_install#31713adaley-openai wants to merge 1 commit into
adaley-openai wants to merge 1 commit into
Conversation
cravuri-oai
reviewed
Jul 10, 2026
| ], | ||
| format!( | ||
| "# Request plugin/connector install\n\nUse this tool only after `{LIST_AVAILABLE_PLUGINS_TO_INSTALL_TOOL_NAME}` returns a plugin or connector that exactly matches the user's explicit request.\n\nDo not use it for adjacent capabilities, broad recommendations, or tools that merely seem useful. Pass the returned `tool_type` through directly, and pass the returned `id` as `tool_id`.\n\nIMPORTANT: DO NOT call this tool in parallel with other tools." | ||
| "# Request plugin/connector install\n\nUse this tool only after `{LIST_AVAILABLE_PLUGINS_TO_INSTALL_TOOL_NAME}` returns a plugin or connector that exactly matches the user's explicit request, or another tool returns an exact remote plugin id relevant to that request.\n\nDo not use it for adjacent capabilities, broad recommendations, or tools that merely seem useful. Do not guess remote plugin ids. For discoverable tools, pass the returned `tool_type` and `id` through directly. For a remote plugin, pass its exact id as `tool_id` and use `tool_type=\"plugin\"`.\n\nIMPORTANT: DO NOT call this tool in parallel with other tools." |
There was a problem hiding this comment.
When testing, I'm seeing this:
I think this behavior is a bit too restrictive. Maybe changing the wording here so it removes some of the details around another tool needing to return the plugin id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_plugin_installto accept a non-empty remote plugin ID up to 256 bytes when the remote-plugin feature is enabled, even when that ID is absent from recommendation candidates.Notes
Validation
just test -p codex-core request_plugin_install— 17 passed.just fix -p codex-corejust fmtgit diff --check