[codex] Reuse parsed plugin skills during session startup#28844
Draft
xl-openai wants to merge 2 commits into
Draft
[codex] Reuse parsed plugin skills during session startup#28844xl-openai wants to merge 2 commits into
xl-openai wants to merge 2 commits into
Conversation
34763b5 to
4edd999
Compare
4edd999 to
242d739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginSkillsCache.Why
Plugin discovery already parses plugin skills to determine available capabilities. Cold session startup then scanned and parsed the same roots again while building the skills snapshot.
This solves the same duplicate-work problem as #28623 while keeping ownership explicit: one full plugin load creates one snapshot cache, and
PluginsManagerstores it with that load's plugin result. It does not add a load-result struct, optional cache parameter, parallel*_with_cacheAPI, separate cache generation, capacity policy, orSkillsWatchercoupling.Validation
just test -p codex-core-plugins plugin_cache_reuses_skills_parsed_during_plugin_loadjust test -p codex-core-plugins read_plugin_for_config_uses_user_layer_skill_settings_onlyjust test -p codex-core-plugins plugin_skill_loading_dedupes_overlapping_manifest_rootsjust test -p codex-core-skills -p codex-core-plugins(359 tests)just test -p codex-core capability_sections_render_in_developer_message_in_ordercodex execprobe against a mock Responses server: the configured plugin skill root enteredload_skill_rootexactly once.just fix -p codex-core-pluginsjust fmt