[codex] persist fsmonitor status refreshes#28843
Open
tamird wants to merge 1 commit into
Open
Conversation
Codex runs internal Git commands with GIT_OPTIONAL_LOCKS=0. This prevents status from writing the refreshed fsmonitor token after daemon restarts, so each background status scans the worktree until another process updates the index. Allow optional locks only for status using built-in fsmonitor. Keep the lock-taking child owned after the caller timeout so Git can finish or roll back its index lock. Other internal commands retain their existing timeout with optional locks disabled. In an 894,963-entry worktree after a daemon restart, two status runs with optional locks disabled took 7.45s and 7.01s. With this change they took 8.01s and 92ms.
tamird
force-pushed
the
codex/persist-fsmonitor-refresh
branch
from
7403967 to
e1e1e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex runs internal Git commands with GIT_OPTIONAL_LOCKS=0. This
prevents status from writing the refreshed fsmonitor token after daemon
restarts, so each background status scans the worktree until another
process updates the index.
Allow optional locks only for status using built-in fsmonitor. Keep the
lock-taking child owned after the caller timeout so Git can finish or
roll back its index lock. Other internal commands retain their existing
timeout with optional locks disabled.
In an 894,963-entry worktree after a daemon restart, two status runs
with optional locks disabled took 7.45s and 7.01s. With this change they
took 8.01s and 92ms.