feat(app-server): complete filesystem host semantics#28829
Draft
nornagon-openai wants to merge 1 commit into
Draft
feat(app-server): complete filesystem host semantics#28829nornagon-openai wants to merge 1 commit into
nornagon-openai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex Apps is adapting app-server connections to its
ExecutionHostinterface. The filesystem API currently lacks several semantics that callers rely on, which forces adapters either to reject valid operations or silently change behavior.What
fs/getMetadata.followSymlinks: false.sizeBytesto filesystem metadata.isSymlinkto directory entries.fs/copy.exclusive.{ "code": "EEXIST" }app-server error data.Streaming file operations are intentionally separate and tracked by #27190.
Validation
cargo test -p codex-app-server-protocolcargo test -p codex-app-server fs_ --no-fail-fastcodex-exec-serverlocal and remote tests for metadata, directory symlinks, and exclusive copiescargo check --tests -p codex-corejust fix -p codex-file-system -p codex-exec-server -p codex-app-server-protocol -p codex-app-serverjust fmt