[app-server] improve thread list and resume rpc paths#28801
Open
anaiskillian wants to merge 2 commits into
Open
[app-server] improve thread list and resume rpc paths#28801anaiskillian wants to merge 2 commits into
anaiskillian wants to merge 2 commits into
Conversation
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 135772bf29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thread/list, using list-specific row types so the app-server only reads the fields needed for list responses instead of materializing the full thread. It preserves the existing filters, parent filtering, ordering, anchors, and repair validation while reducing the amount of DB work on the hot list path.thread/resumehas a 1.56x improvement on cold resume and 4.47x on exclude-turns resume, whilethread/listimproves about 3.45x on the 100 thread DB-backed case, about 4.39x on the 6000-thread DB-backed case, about 4.76x when listing 6000 threads with source filters, 11.72x when listing child threads for one parent, and 6.76x on the scan-and-repair case. I ranjust fmt,CARGO_INCREMENTAL=0 just fix -p codex-app-server -p codex-core -p codex-rollout -p codex-state -p codex-thread-store,CARGO_INCREMENTAL=0 just test -p codex-app-server --test all thread_list,CARGO_INCREMENTAL=0 just test -p codex-app-server --test all thread_resume,CARGO_INCREMENTAL=0 just test -p codex-state,CARGO_INCREMENTAL=0 just test -p codex-rollout -p codex-thread-store, andCARGO_INCREMENTAL=0 just test -p codex-core --liblocally.