[codex] Support plugin manifest path lists#28790
Merged
charlesgong-openai merged 7 commits intoJun 18, 2026
Merged
Conversation
xl-openai
reviewed
Jun 17, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b7811e610
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xl-openai
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow plugin manifests to declare
skillsas either a single path string or an array of path strings in the core plugin loader.Why
Some plugin packages need to expose skills from more than one directory. Before this change,
plugin.jsononly accepted a single string forskills, so manifests like this were ignored as an invalidskillsshape:{ "skills": ["./skills/abc", "./skills/edk"] }This keeps the existing single-string form working while adding support for the list form. The final scope is intentionally limited to the core plugin manifest/load path for
skills;apps, file-backedmcpServers, and the bundled plugin-creator assets are unchanged in this PR.What changed
skillsas either a string or an array of strings inplugin.json.PluginManifestPaths../skillsroot.SKILL.mdpath for overlapping roots such as./skillsplus./skills/abc.skillsskills./skillsas a manifest path./skills/abcand./skills/edkValidation
just test -p codex-pluginjust test -p codex-core-pluginsjust test -p codex-mcp-extensiongit diff --check