[codex] Support marketplace plugin manifest fallback#28789
Draft
charlesgong-openai wants to merge 1 commit into
Draft
[codex] Support marketplace plugin manifest fallback#28789charlesgong-openai wants to merge 1 commit into
charlesgong-openai wants to merge 1 commit into
Conversation
21e54f0 to
7da943b
Compare
7da943b to
ee33893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support marketplace plugins whose source directory does not include a discoverable plugin manifest. Marketplace entries now synthesize a fallback
.codex-plugin/plugin.jsonfrom supportedmarketplace.jsonfields and use that metadata for local detail reads, install, and non-curated cache refresh.The install path stages a temporary source copy before writing the fallback manifest, so local marketplace checkout contents are not mutated. Existing source manifests still take precedence when present.
Details
version,description,keywords,skills,mcpServers,apps,hooks, andinterface.interface, including descriptions, developer/category metadata, capabilities, URLs, default prompts, brand color, icons, logos, and screenshots.author.nametointerface.developerNameand marketplacecategoryto the plugin interface category; unsupported marketplace-only keys such asagentsare not written into the generatedplugin.json.skillsas either a string or array in marketplace entries, using the first valid path for the synthesized plugin manifest because the current plugin manifest schema supports a single skills root.name/sourceentries.Validation
CARGO_TARGET_DIR=/tmp/codex-target just test -p codex-app-server plugin_read_returns_invalid_request_when_plugin_manifest_is_missingpassed: 1/1.CARGO_TARGET_DIR=/tmp/codex-target just test -p codex-core-pluginspassed: 252/252.CARGO_TARGET_DIR=/tmp/codex-target just fix -p codex-core-pluginscompleted; it reported an existing unrelatedlarge_enum_variantwarning incore-plugins/src/manifest.rs.just fmtpassed.