fix(ci): use supported release workflow concurrency - #324
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83848e1eec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| concurrency: | ||
| group: node-release-cut | ||
| queue: max | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
Preserve every pending release run
When one run is active and two more releases enter the same concurrency group, cancel-in-progress: false protects only the active run: GitHub documents that there can be “at most one running and one pending job” and that a new queued run replaces the existing pending run. Consequently, the analogous changes in node-release-cut.yml, node-release.yml, and node-github-release.yml can discard an intermediate version/tag or backfill during overlapping releases, despite the tests claiming every release is serialized; these workflows need a durable dispatch/queue mechanism rather than treating cancel-in-progress: false as equivalent to queue: max.
Useful? React with 👍 / 👎.
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
concurrency.queuewith GitHub-supportedcancel-in-progress: falsein release cutting, protected npm publishing, and GitHub release publication.Verification
bun test --timeout 30000 tests-ts/release-automation.test.ts tests-ts/release-cut-workflow.test.ts tests-ts/skeleton.test.ts(201 passing)tsc --noEmit --incremental false