fix: lower the SessionEnd hook timeout to Codex CLI's 3s cap - #619
Open
epsalmond wants to merge 1 commit into
Open
fix: lower the SessionEnd hook timeout to Codex CLI's 3s cap#619epsalmond wants to merge 1 commit into
epsalmond wants to merge 1 commit into
Conversation
Codex CLI clamps SessionEnd hook timeouts to 3 seconds (SESSION_END_MAX_TIMEOUT_SEC in codex-rs/hooks/src/events/session_end.rs) and warns on every startup when the manifest declares more. Declare 3s so the manifest matches what actually runs and the warning goes away. Fixes openai#582
epsalmond
marked this pull request as ready for review
August 9, 2026 00:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex CLI clamps
SessionEndhook timeouts to 3 seconds (SESSION_END_MAX_TIMEOUT_SECincodex-rs/hooks/src/events/session_end.rs) and prints a warning on every startup when a manifest declares more:The bundled manifest declares 5 seconds, so every session that loads the plugin starts with this warning while the hook runs under a 3-second budget anyway. This lowers the declared timeout to 3 so the manifest matches what actually runs. The
SessionStartandStoptimeouts are untouched — Codex does not clamp those.Fixes #582
Validation
node --test tests/commands.test.mjs— 8 passed, including a new assertion that theSessionEndtimeout stays within the 3-second capnpm test— 87 passed; the 4 failures (status/result/resolveStateDirtests) fail identically on a clean checkout ofmainin this environmentnpm run check-version— all version metadata matches 1.0.6