[Night Shift] Fix session env leak #338#339
Open
Pgarciapg wants to merge 6 commits into
Open
Conversation
…olation Add tests/args.test.mjs covering parseArgs (boolean flags, value options, inline values, short aliases, passthrough positionals, missing value error) and splitRawArgumentString (space splitting, single/double quotes, backslash escaping, trailing backslash). Add tests/prompts.test.mjs covering interpolateTemplate (single key, multiple keys, unknown key, no placeholders, duplicate key). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover graceful output when codex returns empty stdout, correct error message formatting on non-zero exit codes and signals, timeout/stall handling with slow-task and interruptible-slow-task behaviors, cancel interruption of running turns, parseStructuredOutput edge cases, and binaryAvailable for missing binaries. Add "empty-stdout" behavior to the fake codex fixture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…EADME The README documented all 7 commands and the rescue subagent but omitted the three internal skills (codex-cli-runtime, codex-result-handling, gpt-5-4-prompting) that ship with the plugin. Add them to the "After install" section with a note that they are not user-invocable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a 5-second timeout to sendBrokerShutdown to prevent indefinite hangs during SessionEnd hook. Implements proper cleanup matching the pattern used in waitForBrokerEndpoint with timer.unref() for graceful shutdown. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add --context flag to allow users to pass additional context string when delegating tasks. The context is appended to the prompt with a separator. Updates argument parsing, passes context through task request flow, and documents the flag in SKILL.md and commands. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…GIN_DATA The session-lifecycle-hook was exporting CLAUDE_PLUGIN_DATA which is a shared namespace used by all Claude Code plugins. This could cause conflicts when multiple plugins are installed. Changes: - Export plugin data dir as CODEX_PLUGIN_DATA instead of CLAUDE_PLUGIN_DATA - Update state.mjs to read CODEX_PLUGIN_DATA first, falling back to CLAUDE_PLUGIN_DATA - Update tests to expect the new env var name Fixes openai#338 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Work Items Completed
Work Items Skipped
Test plan
🤖 Generated with Claude Code