fix(OpenAI): trim streamed response data before decoding- #9 - #806
Merged
Merged
Conversation
Support streaming compaction output
Collaborator
|
Clever trick to reduce a copy - just trim off front/end prior to decode. |
iBotPeaches
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Streaming response lines may contain boundary control characters such as a trailing NUL byte. Passing those bytes directly to
json_decode()causes aJSON_ERROR_CTRL_CHARexception even when the JSON payload itself is valid.This change trims the same boundary characters handled by PHP
trim()before decoding the SSEdata:value. The extraction calculates the trimmed boundaries first and creates only one resulting string, avoiding the additional full-size allocation produced bytrim(substr(...)). This is important for large streamed events such as context compaction payloads, which can be tens of megabytes.A regression test covers a valid streamed compaction event followed by a NUL byte and verifies that it is decoded successfully.