Skip to content

Make default values static #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtomic28 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make default values static #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/asam_cmp_capture_module/src/interface_fb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ void InterfaceFb::removeStreamInternal(size_t nInd)
void InterfaceFb::initProperties()
{
auto propName = "VendorData";
auto prop = StringPropertyBuilder(propName, vendorDataAsString).build();
auto prop = StringPropertyBuilder(propName, "").build();
objPtr.addProperty(prop);
objPtr.setPropertyValue(propName, vendorDataAsString);
objPtr.getOnPropertyValueWrite(propName) +=
[this](PropertyObjectPtr& obj, PropertyValueEventArgsPtr& args) { propertyChangedIfNotUpdating(); };
}
Expand Down
3 changes: 2 additions & 1 deletion shared/libraries/asam_cmp_common_lib/include/asam_cmp_common_lib/stream_common_fb_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ template <typename... Interfaces>
void StreamCommonFbImpl<Interfaces...>::initProperties()
{
StringPtr propName = "StreamId";
auto prop = IntPropertyBuilder(propName, streamId)
auto prop = IntPropertyBuilder(propName, 0)
.setMinValue(static_cast<Int>(std::numeric_limits<uint8_t>::min()))
.setMaxValue(static_cast<Int>(std::numeric_limits<uint8_t>::max()))
.build();
this->objPtr.addProperty(prop);
this->objPtr.setPropertyValue(propName, static_cast<Int>(streamId));
this->objPtr.getOnPropertyValueWrite(propName) +=
[this](PropertyObjectPtr& obj, PropertyValueEventArgsPtr& args) { updateStreamIdInternal(); };
}
Expand Down
3 changes: 2 additions & 1 deletion shared/libraries/asam_cmp_common_lib/src/interface_common_fb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,12 @@ FunctionBlockTypePtr InterfaceCommonFb::CreateType(const ModuleInfoPtr& moduleIn
void InterfaceCommonFb::initProperties()
{
StringPtr propName = "InterfaceId";
auto prop = IntPropertyBuilder(propName, interfaceId)
auto prop = IntPropertyBuilder(propName, 0)
.setMinValue(static_cast<Int>(std::numeric_limits<uint32_t>::min()))
.setMaxValue(static_cast<Int>(std::numeric_limits<uint32_t>::max()))
.build();
objPtr.addProperty(prop);
objPtr.setPropertyValue(propName, static_cast<Int>(interfaceId));
objPtr.getOnPropertyValueWrite(propName) +=
[this](PropertyObjectPtr& obj, PropertyValueEventArgsPtr& args) { propertyChangedIfNotUpdating(); };

Expand Down
Loading