Chrono includes, bugfixes of debug building and a bugfix out of scope reference#61
Merged
Chrono includes, bugfixes of debug building and a bugfix out of scope reference#61
Conversation
A fix of cmake (it failed when compiling under debug config, /bigobj was missing when in this mode), also a small fix when the fixed function was called in the destructor it called a private member.
Contributor
|
Hey, Do you think you could fix the Windows build? |
Contributor
Author
|
For windows build there is already an open PR on the main branch, which should fix the failing. It has to do with a name of a variable being interpreted wrong. |
Updated the GIT_TAG to the updated version of the core opendaq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing chrono includes. Added /bigobj tag to debug cmake. Updated the git_tag. Fixed mutex internal call that was wrong.