docs: use the readiness endpoint on the cloud deployment pages and name the pool, storage and sign-up behaviors - #1425
Open
silentoplayz wants to merge 1 commit into
Conversation
…me the pool, storage and sign-up behaviors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I compared the Kubernetes, ECS, Azure Container Apps and Cloud Run pages with the health endpoints and the storage and pool code.
/health/db, which only pings the database and can answer HTTP 200 before startup (migrations, config seeding, admin creation) has finished. They now use/ready. It waits for startup and also pings Redis.AZURE_STORAGE_KEYis optional. Without it, the blob client usesDefaultAzureCredential, so a managed identity with a Blob data role works.WEBUI_ADMIN_EMAILandWEBUI_ADMIN_PASSWORDturns open sign-up off automatically, and the verification step now says so.DATABASE_POOL_SIZE,DATABASE_POOL_MAX_OVERFLOWandPGVECTOR_POOL_SIZE, and the ingress notes name/ws/socket.io/.Related issue or discussion
None.
Checklist
Notes for reviewers
Sources on
dev:main.py(/ready,/health/db, the env-admin creation that setsui.enable_signupto false, the/wsmount),storage/provider.py(Azure credential fallback),env.py(DATABASE_POOL_*), andconfig.py(PGVECTOR_POOL_*).