Stop posting a first status comment on untracked closed pull requests - #223
Merged
trask merged 1 commit intoAug 4, 2026
Conversation
A `pull_request_review` webhook for a pull request that merged weeks ago still dispatches a targeted refresh. `build_pr_result` returns `None` for a closed pull request, and `merge_dashboard_update_with_latest_state` then reported a state change even when the pull request had never been in the dashboard cache, so there was nothing to drop. That queued a status comment, and `upsert_status_comment` created one, announcing "Merged" on a pull request the dashboard had never commented on. Report no change when nothing was cached for the pull request, and never create a status comment for a terminal state. A terminal status only exists to move an already published comment to its final state. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ca21dec5-33e3-4724-b588-a70626f5435d
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents first-time dashboard status comments from being posted on already-closed, untracked pull requests while preserving final updates for tracked PRs.
Changes:
- Treats removal of an uncached PR as an unchanged dashboard state.
- Adds an option to update status comments without creating them.
- Prevents terminal PR states from creating new comments and adds regression tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
dashboard.py |
Avoids reporting changes when a closed PR was never cached. |
pr_status_comment.py |
Updates existing terminal comments without creating new ones. |
test_dashboard.py |
Tests tracked and untracked closed-PR merge behavior. |
test_pr_status_comment.py |
Tests creation suppression and terminal/open publishing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request dashboard statusMerged · refreshed 2026-08-04 18:28 UTC Status above doesn't look right?
|
mx-psi
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard posted its first status comment on open-telemetry/semantic-conventions#3889 on 2026-08-04, announcing Merged on a pull request that had merged on 2026-07-17. A review comment arrived on the already-merged pull request, and that was enough to make the dashboard introduce itself on a thread it had never been part of.
After this change, a pull request that the dashboard was not already commenting on stays quiet once it is closed or merged. Pull requests it was tracking still get their existing comment moved to Merged or Closed as before.