Fix _BaseConfigurator.__new__ crash for subclasses with __init__ arguments#5441
Open
Eason09053360 wants to merge 3 commits into
Open
Fix _BaseConfigurator.__new__ crash for subclasses with __init__ arguments#5441Eason09053360 wants to merge 3 commits into
Eason09053360 wants to merge 3 commits into
Conversation
Eason09053360
added a commit
to Eason09053360/opentelemetry-python
that referenced
this pull request
Jul 19, 2026
Eason09053360
marked this pull request as ready for review
July 20, 2026 11:33
herin049
reviewed
Jul 23, 2026
| def __new__(cls, *args, **kwargs): | ||
| if cls._instance is None: | ||
| cls._instance = object.__new__(cls, *args, **kwargs) | ||
| cls._instance = object.__new__(cls) |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| cls._instance = object.__new__(cls) | |
| cls._instance = super().__new__(cls) |
Contributor
Author
There was a problem hiding this comment.
Good suggestion!!
Applied
…ments object.__new__ raises TypeError when passed extra arguments if __new__ is overridden, so any Configurator subclass defining an __init__ with parameters crashed on first instantiation. Call object.__new__(cls) without forwarding arguments; type.__call__ still passes them to __init__.
Follows cooperative multiple inheritance conventions so the MRO's __new__ chain isn't silently skipped if a mixin is added later. Co-authored-by: herin049 <40302054+herin049@users.noreply.github.com>
Eason09053360
force-pushed
the
fix-baseconfigurator-new-with-args
branch
from
July 24, 2026 01:00
8611a1c to
0f6abda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_BaseConfigurator.__new__forwards*args, **kwargstoobject.__new__. Since_BaseConfiguratoroverrides__new__, CPython'sobject.__new__raisesTypeError: object.__new__() takes exactly one argumentwhen it receives any extra arguments. As a result, any distro Configurator subclass that defines an__init__with parameters (an extension pattern the docs encourage) crashes on first instantiation.Fix: call
object.__new__(cls)without forwarding arguments —type.__call__still passes them to__init__. The singleton behavior is unchanged.Type of change
How Has This Been Tested?
test_custom_configurator_with_init_args, which fails with theTypeErrorabove before the fix and passes after.TestConfiguratortests still pass.Does This PR Require a Contrib Repo Change?
Checklist: