opentelemetry-api: avoid SelectableGroups dict API#5234
Closed
Mirochill wants to merge 2 commits into
Closed
Conversation
Assisted-by: OpenAI Codex
|
Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5231.
Normalize
importlib.metadataSelectableGroupsthroughselect()instead of the deprecated dict-style interface. This preserves the existing cached all-entry-points behavior while avoiding the Python 3.10/3.11SelectableGroups dict interface is deprecatedwarning path.Type of change
How Has This Been Tested?
git diff --checkgit diff --cached --checkLocal tests, tox, linters, builds, installers, and project scripts were not run, per this workspace policy; remote GitHub CI will be used. A regression test is included for the
SelectableGroups.select()normalization path.Does This PR Require a Contrib Repo Change?
Checklist:
The PR is draft until the first remote checks are available.