opentelemetry-exporter-otlp-proto-http: Update exporter to use new HTTP transport package#5219
Draft
herin049 wants to merge 21 commits into
Draft
opentelemetry-exporter-otlp-proto-http: Update exporter to use new HTTP transport package#5219herin049 wants to merge 21 commits into
herin049 wants to merge 21 commits into
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
opentelemetry-exporter-otlp-proto-httppackage to switch to using the abstractions/utilities added in theopentelemetry-exporter-http-transportpackage. Notably, this involves switching to the sharedOTLPHTTPClientclient (reducing code duplication between exporters), and adding an optional, private_transportargument that accepts an arbitrary transport implementation. These changes also switch to usingurllib3as the default transport, unless the user specifies otherwise, either by directly passing arequestsSession, initializing the_OTEL_PYTHON_EXPORTER_OTLP_HTTP_CREDENTIAL_PROVIDERenvironment variable or directly passing a custom transport via the_transportkeyword argument.Fixes #3439, #4171, #2990
Depends on #5194
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: