Skip to content

sdk: tighten ReadableSpan.attributes to non-Optional Mapping (#4569) #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WatchTree-19 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

sdk: tighten ReadableSpan.attributes to non-Optional Mapping (#4569) #5183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5183.changed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-sdk`: tighten `ReadableSpan.attributes` return type to non-Optional `Mapping`
3 changes: 2 additions & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,8 @@ def status(self) -> trace_api.Status:
return self._status

@property
def attributes(self) -> types.Attributes:
def attributes(self) -> Mapping[str, types.AttributeValue]:
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do / should we update the API definition too?

# `or {}` keeps the return non-None; see #4569.
return MappingProxyType(self._attributes or {})

@property
Expand Down