chore: enable PIE (flake8-pie) ruff rule#5150
Conversation
|
Thanks for the review @DylanRussell! Could a project member take a look when you have a moment? All checks are green. |
|
Friendly bump @DylanRussell has approved and CI is green. Would appreciate a maintainer review when you have a moment. @srikanthccv @aabmass |
261560f to
7b6dbb7
Compare
cac4933 to
8ea69ce
Compare
8ea69ce to
15a5193
Compare
|
Thanks for the PR! Just a heads-up: we no longer update Please add the appropriate changelog fragment for this change instead of editing |
Part of open-telemetry#4227 Adds `PIE` to the ruff lint select list. Fixes all 49 auto-fixable violations (PIE790 unnecessary pass, PIE804 unnecessary dict kwargs, PIE808 unnecessary range start argument). Suppresses PIE796 on GenAiTokenTypeValues.COMPLETION which is an intentional deprecated alias for OUTPUT sharing the same enum value.
15a5193 to
ddec690
Compare
|
@MikeGoldsmith @emdneto thanks for the approvals. The fork PR workflows still need a maintainer to authorize the run, whenever convenient. |
emdneto
left a comment
There was a problem hiding this comment.
Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
ddec690 to
6a4a576
Compare
|
Thanks for the heads-up! Replaced the direct CHANGELOG.md edit with a Towncrier fragment at |
Part of #4227
Adds
PIEto the ruff lintselectlist and fixes all violations.What changed
pyproject.toml: added"PIE"to[tool.ruff.lint] selectpassstatements in exception handlersdict(key=value)with{"key": value}literalsstart=0argument fromrange()calls# noqa: PIE796onGenAiTokenTypeValues.COMPLETIONingen_ai_attributes.py— this is an intentional deprecated alias sharing the same enum value asOUTPUTTesting