feat(logs): implement log creation metric#4935
Open
anuraaga wants to merge 3 commits intoopen-telemetry:mainfrom
Open
feat(logs): implement log creation metric#4935anuraaga wants to merge 3 commits intoopen-telemetry:mainfrom
anuraaga wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
xrmx
approved these changes
Feb 27, 2026
| instrumentation_scope=self._instrumentation_scope, | ||
| ) | ||
|
|
||
| self._logger_metrics.emit_log() |
Contributor
There was a problem hiding this comment.
Maybe call this on_emit as well? emit_log sounds like you are going to emit a new log more than it has been emitted.
| formatter: Callable[ | ||
| [ReadableLogRecord], str | ||
| ] = lambda record: record.to_json() + linesep, | ||
| formatter: Callable[[ReadableLogRecord], str] = lambda record: ( |
Contributor
There was a problem hiding this comment.
Do you have a newer ruff installed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am helping to implement SDK internal metrics
https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/
This implements the metric for created logs. It is very similar to #4880 for spans.
/cc @xrmx to help with review
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: