conformance testing: add granular violation suppressions#89
Open
lmolkova wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a mechanism to declare and suppress specific, known Weaver live-check violations on a per-conformance-scenario basis, enabling tighter default validation while allowing instrumentations with unavoidable gaps to remain conformant.
Changes:
- Introduces
ExpectedViolationandScenario.expected_violations, and adds violation reconciliation inrun_conformance. - Tightens the span validation policy to expect
server.addressfor more operations. - Updates LangChain conformance scenarios to suppress the known
server.addressmissing-attribute violation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| util/opentelemetry-test-util-genai/src/opentelemetry/test_util_genai/conformance.py | Adds ExpectedViolation + enforcement logic so scenarios can declare and suppress specific known violations while still failing on unexpected/new ones. |
| policies/genai_span_validation.rego | Makes server.address an expected attribute across additional operation sets, producing stable advice IDs for suppression. |
| instrumentation/opentelemetry-instrumentation-genai-langchain/tests/conformance/workflow.py | Declares an expected Weaver violation for missing server.address in the workflow scenario. |
| instrumentation/opentelemetry-instrumentation-genai-langchain/tests/conformance/inference.py | Declares an expected Weaver violation for missing server.address in the inference scenario. |
| instrumentation/opentelemetry-instrumentation-genai-langchain/tests/conformance/agent.py | Declares an expected Weaver violation for missing server.address in the agent scenario. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some instrumentations can't populate certain non-required attributes. Add mechanism allowing to suppress specific violations without turning checks off for everyone.