Add tools support in langchain#37
Conversation
…on-genai into tools-langchain
Assisted-by: Claude Opus 4.6
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Looks good, let's just update langchain to use new InferenceInvocation instead of deprecated LLMInvocation
| seed: int | None = None | ||
| server_address: str | None = None | ||
| server_port: int | None = None | ||
| tool_definitions: list[ToolDefinition] | None = None |
There was a problem hiding this comment.
is this necessary? let's update langchain to use new API instead of legacy LLMInvocation
There was a problem hiding this comment.
could you please add a conformance test for tool calling in https://github.com/open-telemetry/opentelemetry-python-genai/tree/main/instrumentation/opentelemetry-instrumentation-langchain/tests/conformance ?
It's testing tool calling along with multi-turn conversations and can be almost copied over from https://github.com/open-telemetry/opentelemetry-python-genai/blob/main/instrumentation/opentelemetry-instrumentation-openai-v2/tests/conformance/tool_calling.py
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
2 participants
examples/tools/main.py
Tools span:
Inference spans with tool details:
