Move logger handlers to opentelemetry-instrumentation-logging#4210
Open
xrmx wants to merge 23 commits intoopen-telemetry:mainfrom
Open
Move logger handlers to opentelemetry-instrumentation-logging#4210xrmx wants to merge 23 commits intoopen-telemetry:mainfrom
xrmx wants to merge 23 commits intoopen-telemetry:mainfrom
Conversation
xrmx
commented
Feb 18, 2026
...n/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/handler.py
Show resolved
Hide resolved
pmcollins
reviewed
Feb 18, 2026
Member
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
Looks nice -- added a couple of questions.
opentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/_load.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-logging/pyproject.toml
Outdated
Show resolved
Hide resolved
xrmx
changed the title
xrmx
commented
Feb 20, 2026
instrumentation/opentelemetry-instrumentation-logging/tests/test_handler.py
Show resolved
Hide resolved
xrmx
commented
Feb 23, 2026
.../opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py
Outdated
Show resolved
Hide resolved
And hook it up via entry point
No change in practice
xrmx
force-pushed
the
move-logger-handlers-to-autoinstrumentation
branch
from
1002797 to
267f85b
Compare
xrmx
commented
Feb 23, 2026
.../opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Added tests, fixed leaks and a wrong test in the copied sdk tests 😓 Added the removal of the handler on uninstrument() if it was instrumented. |
emdneto
reviewed
Feb 24, 2026
...n/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/handler.py
Show resolved
Hide resolved
.../opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py
Show resolved
Hide resolved
emdneto
reviewed
Feb 25, 2026
.../opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py
Show resolved
Hide resolved
Contributor
Author
|
Genai examples updated in #4263 |
...opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/constants.py
Show resolved
Hide resolved
rads-1996
reviewed
Feb 26, 2026
| thread.start() | ||
|
|
||
|
|
||
| _STD_TO_OTEL = { |
Contributor
There was a problem hiding this comment.
can't we reference this piece of code from here
Contributor
Author
There was a problem hiding this comment.
The instrumentations does not have a dependency on the sdk and that code in the sdk will be removed in the future. Likely we are going to move some of this code into another package if this is going to be shared by handlers for other log libraries.
rads-1996
reviewed
Feb 26, 2026
...opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/constants.py
Outdated
Show resolved
Hide resolved
.../opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py
Show resolved
Hide resolved
xrmx
commented
Feb 27, 2026
...opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/constants.py
Outdated
Show resolved
Hide resolved
| thread.start() | ||
|
|
||
|
|
||
| _STD_TO_OTEL = { |
Contributor
Author
There was a problem hiding this comment.
The instrumentations does not have a dependency on the sdk and that code in the sdk will be removed in the future. Likely we are going to move some of this code into another package if this is going to be shared by handlers for other log libraries.
…telemetry/instrumentation/logging/constants.py
tammy-baylis-swi
approved these changes
Feb 27, 2026
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thanks for all the adjustments. Lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR for sketching LoggingHandler move outside of sdk.
Refs open-telemetry/opentelemetry-python#4330
Fixes open-telemetry/opentelemetry-python#4316
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.