Skip to content

fix: dependabot#2200

Merged
wpessers merged 1 commit intodependabot/npm_and_yarn/nodejs/nodejs-other-90377ec089from
maxday/fix-dependabot
Mar 23, 2026
Merged

fix: dependabot#2200
wpessers merged 1 commit intodependabot/npm_and_yarn/nodejs/nodejs-other-90377ec089from
maxday/fix-dependabot

Conversation

@maxday
Copy link
Member

@maxday maxday commented Mar 23, 2026

This PR fixes the issue in #2195 where CI for nodejs is failing with:

...
tsc --build tsconfig.json
Error: ../../node_modules/@types/eslint-scope/index.d.ts(7,5): error TS2416: Property 'scopes' in type 'ScopeManager' is not assignable to the same property in base type 'ScopeManager'.
...

This error is raised when we type check dependencies. @types/eslint-scope is brought via webpack and I think we don't really care about type checking this that's why I introduced the skipLibCheck where typescript skip validation on 3rd pary lib (see: https://www.typescriptlang.org/tsconfig/#skipLibCheck)

From the doc, it seems that it's exactly the perfect use case to use it.

Another possibility is when you are migrating between TypeScript releases and the changes cause breakages in node_modules and the JS standard libraries which you do not want to deal with during the TypeScript update.

The target of this PR is the dependabot PR so CI should be green here if the fix is working :)

@maxday maxday requested a review from a team as a code owner March 23, 2026 18:49
wpessers
wpessers approved these changes Mar 23, 2026
View reviewed changes
Copy link
Member

@wpessers wpessers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is indeed reasonable for us to assume that our runtime dependencies (mostly opentelemetry deps) are well-maintained and ship reliable types. So I agree with this change, good find! Thanks for fixing! 🚀

@wpessers wpessers merged commit 5123c23 into dependabot/npm_and_yarn/nodejs/nodejs-other-90377ec089 Mar 23, 2026
5 checks passed
@wpessers wpessers deleted the maxday/fix-dependabot branch March 23, 2026 21:41
@wpessers wpessers added enhancement New feature or request javascript Pull requests that update Javascript code labels Mar 23, 2026
wpessers pushed a commit that referenced this pull request Mar 23, 2026
@dependabot @maxday
build(deps-dev): bump the nodejs-other group across 2 directories wit…
fd5ba94 
…h 11 updates (#2195)

* build(deps-dev): bump the nodejs-other group across 2 directories with 11 updates

Bumps the nodejs-other group with 11 updates in the /nodejs directory:

| Package | From | To |
| --- | --- | --- |
| [bestzip](https://github.com/nfriedly/node-bestzip) | `2.2.1` | `2.2.2` |
| [eslint](https://github.com/eslint/eslint) | `9.39.4` | `10.1.0` |
| [globals](https://github.com/sindresorhus/globals) | `15.15.0` | `17.4.0` |
| [lerna](https://github.com/lerna/lerna/tree/HEAD/packages/lerna) | `9.0.3` | `9.0.7` |
| [rimraf](https://github.com/isaacs/rimraf) | `6.1.2` | `6.1.3` |
| [sinon](https://github.com/sinonjs/sinon) | `21.0.0` | `21.0.3` |
| [webpack](https://github.com/webpack/webpack) | `5.104.1` | `5.105.4` |
| [webpack-cli](https://github.com/webpack/webpack-cli) | `6.0.1` | `7.0.2` |
| [@aws-sdk/client-sts](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-sts) | `3.948.0` | `3.1014.0` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `24.5.2` | `25.5.0` |
| [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) | `2.232.2` | `2.244.0` |

Bumps the nodejs-other group with 1 update in the /nodejs/packages/layer directory: [webpack-cli](https://github.com/webpack/webpack-cli).


Updates `bestzip` from 2.2.1 to 2.2.2
- [Commits](nfriedly/node-bestzip@v2.2.1...v2.2.2)

Updates `eslint` from 9.39.4 to 10.1.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.4...v10.1.0)

Updates `globals` from 15.15.0 to 17.4.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v15.15.0...v17.4.0)

Updates `lerna` from 9.0.3 to 9.0.7
- [Release notes](https://github.com/lerna/lerna/releases)
- [Changelog](https://github.com/lerna/lerna/blob/main/packages/lerna/CHANGELOG.md)
- [Commits](https://github.com/lerna/lerna/commits/v9.0.7/packages/lerna)

Updates `rimraf` from 6.1.2 to 6.1.3
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v6.1.2...v6.1.3)

Updates `sinon` from 21.0.0 to 21.0.3
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v21.0.0...v21.0.3)

Updates `webpack` from 5.104.1 to 5.105.4
- [Release notes](https://github.com/webpack/webpack/releases)
- [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md)
- [Commits](webpack/webpack@v5.104.1...v5.105.4)

Updates `webpack-cli` from 6.0.1 to 7.0.2
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@6.0.1...webpack-cli@7.0.2)

Updates `@aws-sdk/client-sts` from 3.948.0 to 3.1014.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sts/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.1014.0/clients/client-sts)

Updates `@types/node` from 24.5.2 to 25.5.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `aws-cdk-lib` from 2.232.2 to 2.244.0
- [Release notes](https://github.com/aws/aws-cdk/releases)
- [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md)
- [Commits](https://github.com/aws/aws-cdk/commits/v2.244.0/packages/aws-cdk-lib)

Updates `sinon` from 21.0.0 to 21.0.3
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v21.0.0...v21.0.3)

Updates `webpack` from 5.104.1 to 5.105.4
- [Release notes](https://github.com/webpack/webpack/releases)
- [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md)
- [Commits](webpack/webpack@v5.104.1...v5.105.4)

Updates `webpack-cli` from 6.0.1 to 7.0.2
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@6.0.1...webpack-cli@7.0.2)

Updates `webpack-cli` from 6.0.1 to 7.0.2
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@6.0.1...webpack-cli@7.0.2)

---
updated-dependencies:
- dependency-name: bestzip
  dependency-version: 2.2.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: nodejs-other
- dependency-name: eslint
  dependency-version: 10.1.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: nodejs-other
- dependency-name: globals
  dependency-version: 17.4.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: nodejs-other
- dependency-name: lerna
  dependency-version: 9.0.7
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: nodejs-other
- dependency-name: rimraf
  dependency-version: 6.1.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: nodejs-other
- dependency-name: sinon
  dependency-version: 21.0.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: nodejs-other
- dependency-name: webpack
  dependency-version: 5.105.4
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: nodejs-other
- dependency-name: webpack-cli
  dependency-version: 7.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: nodejs-other
- dependency-name: "@aws-sdk/client-sts"
  dependency-version: 3.1014.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: nodejs-other
- dependency-name: "@types/node"
  dependency-version: 25.5.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: nodejs-other
- dependency-name: aws-cdk-lib
  dependency-version: 2.244.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: nodejs-other
- dependency-name: sinon
  dependency-version: 21.0.3
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: nodejs-other
- dependency-name: webpack
  dependency-version: 5.105.4
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: nodejs-other
- dependency-name: webpack-cli
  dependency-version: 7.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: nodejs-other
- dependency-name: webpack-cli
  dependency-version: 7.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: nodejs-other
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(nodejs): enable skipLibCheck (#2200)

skip type checking of transitive type declarations

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maxime David <maxday@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpessers wpessers wpessers approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxday @wpessers