Skip to content

Avoid shared internal code in sender-jdk and trace-propagators - #9039

Draft
rooks-ns wants to merge 1 commit into
open-telemetry:mainfrom
rooks-ns:fix/avoid-shared-internal-senders
Draft

rooks-ns wants to merge 1 commit into
open-telemetry:mainfrom
rooks-ns:fix/avoid-shared-internal-senders

Conversation

@rooks-ns

Copy link
Copy Markdown
Contributor

Description

Continues progress on #6970 ("Strengthen versioning requirements" / "Avoid shared internal code") by eliminating cross-module internal dependencies and un-exempting artifacts:

  1. RetryUtil: Relocated from io.opentelemetry.exporter.internal to io.opentelemetry.exporter.impl in opentelemetry-exporter-common with the standard @OtelImplJavadoc disclaimer and updated callers.
  2. DaemonThreadFactory: Relocated from io.opentelemetry.sdk.common.internal to io.opentelemetry.sdk.common.impl in opentelemetry-sdk-common with the standard @OtelImplJavadoc disclaimer and updated callers.
  3. Un-exemptions in NoSharedInternalCodeTest:
    • opentelemetry-exporter-sender-jdk
    • opentelemetry-extension-trace-propagators

Related Issues

- Relocate RetryUtil to io.opentelemetry.exporter.impl and update callers
- Relocate DaemonThreadFactory to io.opentelemetry.sdk.common.impl and update callers
- Un-exempt opentelemetry-exporter-sender-jdk and opentelemetry-extension-trace-propagators
@otelbot otelbot Bot added the api-change Changes to public API surface area label Nov 14, 2026
@otelbot

otelbot Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ API changes detected — additional maintainer review required

@jack-berg @jkwatson

This PR modifies the public API surface area of the following module(s):

  • opentelemetry-exporter-common
  • opentelemetry-sdk-common

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

@opentelemetry-pr-dashboard

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-11-14 22:17 UTC

Move out of draft to request review.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.45%. Comparing base (4ce8c01) to head (3361ecf).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9039      +/-   ##
============================================
- Coverage     90.45%   90.45%   -0.01%     
+ Complexity    11179    11178       -1     
============================================
  Files          1032     1032              
  Lines         30500    30500              
  Branches       3991     3991              
============================================
- Hits          27590    27588       -2     
  Misses         1935     1935              
- Partials        975      977       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to public API surface area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant