Repository navigation
Conversation
- Demote api:incubator from api to implementation dependency to prevent transitive compile-scope leakage in published POM metadata - Update DeclarativeConfigResult.getSdk() to return public stable OpenTelemetrySdk instead of internal ExtendedOpenTelemetrySdk - Add PublicApiUsageTest to validate end-to-end consumer usage using only public APIs - Update create and factory tests to match OpenTelemetrySdk
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-14 17:34 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9038 +/- ##
============================================
- Coverage 90.44% 90.43% -0.01%
- Complexity 11171 11177 +6
============================================
Files 1032 1032
Lines 30451 30500 +49
Branches 3974 3991 +17
============================================
+ Hits 27540 27583 +43
- Misses 1935 1939 +4
- Partials 976 978 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rooks-ns
marked this pull request as ready for review
November 14, 2026 17:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #8402.
Refines the public contract and dependency boundaries of
opentelemetry-sdk-extension-declarative-configin preparation for stabilization:api(project(":api:incubator"))toimplementationinbuild.gradle.kts, preventingopentelemetry-api-incubatorfrom leaking onto downstream consumers' compile classpaths via Maven POM metadata.DeclarativeConfigResult.getSdk()from internalExtendedOpenTelemetrySdkto the canonical stableOpenTelemetrySdk. This removes cross-artifact.internalleakage and prevents runtime classloader failure whenapi:incubatoris absent.PublicApiUsageTestproving end-to-end configuration parsing, model mutation, and SDK initialization using strictly public APIs without incubator dependencies.OpenTelemetrySdk.Testing
./gradlew :sdk-extensions:declarative-config:check(passes all unit tests,animalsnifferMain,checkstyleMain, andspotlessCheck).