Repository navigation
Conversation
jack-berg
commented
Nov 13, 2026
Member
- Changelog advice: don't add since entries are automatically added during the release. Would need to revisit if we add dedicated changelog tooling, but for now this reflects reality.
- Dependency isolation: reflects how we've implemented functionality which has load bearing dependency on 3rd party library, like OTLP exporters on http / grpc clients, and declarative config on yaml parsing and object conversion. The advice is:
- Make the dependency pluggable via SPI
- Name the implementations of the SPI modules to include the dependency major version in the name such that a new module can be published when a new major version of the dependency is published
Pull request dashboard statusWaiting on maintainers · refreshed 2026-11-13 16:11 UTC Merge when ready. Status above doesn't look right?
|
jaydeluca
approved these changes
Nov 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9034 +/- ##
============================================
- Coverage 90.45% 90.45% -0.01%
Complexity 11179 11179
============================================
Files 1032 1032
Lines 30500 30500
Branches 3991 3991
============================================
- Hits 27590 27589 -1
Misses 1935 1935
- Partials 975 976 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.