Make declarative config parsing and mapping pluggable by ash-thakur-rh · Pull Request #8983 · open-telemetry/opentelemetry-java

ash-thakur-rh · 2026-10-28T13:51:16Z

Description:

Added a dedicated declarative-config-spi module for the mapper and YAML parser interfaces.
Added the Jackson 2 mapper as a runtime dependency so it is available by default.
Added the SnakeYAML engine 2 parser as a runtime dependency so it is available by default.
Documented how to exclude the Jackson 2 mapper and register a custom mapper, such as one using Jackson 3, likewise with SnakeYAML engine 2 parser.
Updated OSGi metadata and integration coverage for declarative configuration.
Updated the declarative configuration README and changelog.
Verified the affected declarative config, autoconfigure, API incubator, Graal, and OSGi test suites. Will fix other if there are other test failures.
Did a manual end-to-end check in a local consumer project, excluded the Jackson 2 adapter, registered a Jackson 3 mapper through ServiceLoader, and verified configuration parsing and mapping.

Add parser and mapper SPIs, and move the Jackson 2 mapper into an optional adapter module. Signed-off-by: Ashish Thakur <ashishth@redhat.com>

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

linux-foundation-easycla · 2026-10-28T13:51:25Z

The committers listed above are authorized under a signed CLA.

✅ login: ash-thakur-rh / name: Ashish Thakur (1b41300, 93ffc5d, a103e4d)

opentelemetry-pr-dashboard · 2026-10-28T13:52:55Z

Pull request dashboard status

Merged · refreshed 2026-11-13 01:38 UTC

Status above doesn't look right?

Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

codecov · 2026-10-28T14:08:36Z

Codecov Report

❌ Patch coverage is 90.78947% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.43%. Comparing base (95f25dd) to head (f283bcd).

Files with missing lines	Patch %	Lines
...g/internal/DeclarativeConfigurationMapperUtil.java	40.00%	6 Missing ⚠️
...re/declarativeconfig/DeclarativeConfiguration.java	77.77%	4 Missing ⚠️
...nfig/internal/DeclarativeConfigProviderLoader.java	91.17%	1 Missing and 2 partials ⚠️
...veconfig/model/internal/ExtensionPropertyUtil.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8983      +/-   ##
============================================
- Coverage     90.46%   90.43%   -0.04%     
- Complexity    11152    11170      +18     
============================================
  Files          1028     1032       +4     
  Lines         30382    30451      +69     
  Branches       3966     3974       +8     
============================================
+ Hits          27486    27537      +51     
- Misses         1922     1936      +14     
- Partials        974      978       +4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

ash-thakur-rh · 2026-10-28T14:37:41Z

The committers listed above are authorized under a signed CLA.

✅ login: ash-thakur-rh / name: Ashish Thakur (1b41300, 93ffc5d, a103e4d, bf33c6f)

jack-berg

This is pretty close to the shape I imagined. Couple of things to think through tho.

ash-thakur-rh · 2026-11-05T04:59:24Z

This is pretty close to the shape I imagined. Couple of things to think through tho.

Thanks @jack-berg , will take care of the things suggested.

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

ash-thakur-rh · 2026-11-11T11:23:52Z

/dashboard route:reviewers

opentelemetry-pr-dashboard · 2026-11-11T11:24:06Z

@ash-thakur-rh, this pull request was routed to reviewers. The handoff remains active across pushes until newer actionable human feedback arrives. Top-level feedback through this request will not return; unresolved review threads remain open.

jack-berg · 2026-11-11T12:48:18Z

+      Logger.getLogger(DeclarativeConfigProviderLoader.class.getName());
+
+  private static final ComponentLoader COMPONENT_LOADER =
+      ComponentLoader.forClassLoader(DeclarativeConfigProperties.class.getClassLoader());


We need to find a way for ComponentLoader to be a part of the contract and passed through from the caller. Every time we've loaded SPIs previously using a convenient class loader available to us, we eventually get an issue opened where someone needs that class loader to be configurable. That's why you see setComponentLoader style methods everywhere.

This is going to be disruptive for ExtensionPropertyUtil, which calls DeclarativeConfigurationMapper, and maybe the contracts in DeclarativeConfiguration itself since the parse operation currently doesn't have any overload which includes a ComponentLoader. If it proves too disruptive, let's skip and open an issue to followup.

agree, I will open a followup issue after this PR is merged

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

ash-thakur-rh · 2026-11-12T17:01:12Z

Hi @jack-berg , took care of all the review comments. Pls have a look. Thanks!

ash-thakur-rh · 2026-11-12T17:02:50Z

/dashboard route:reviewers

opentelemetry-pr-dashboard · 2026-11-12T17:04:34Z

@ash-thakur-rh, this pull request was routed to reviewers. The handoff remains active across pushes until newer actionable human feedback arrives. Top-level feedback through this request will not return; unresolved review threads remain open.

…y-java into features/fe-config-spi

jack-berg

Pushed a72d54f with some final bits of review feedback.

Thanks!

…y-java into features/fe-config-spi

otelbot · 2026-11-13T01:38:47Z

Thank you for your contribution @ash-thakur-rh! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

ash-thakur-rh added 2 commits October 28, 2026 17:26

feat: Make declarative config parsing and mapping pluggable

1b41300

Add parser and mapper SPIs, and move the Jackson 2 mapper into an optional adapter module. Signed-off-by: Ashish Thakur <ashishth@redhat.com>

feat: dependency fix based on tests run

a103e4d

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

opentelemetry-pr-dashboard Bot mentioned this pull request Oct 28, 2026

Pull Request Dashboard #8439

Open

feat: few changes for better arch

93ffc5d

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

ash-thakur-rh marked this pull request as ready for review October 29, 2026 05:26

ash-thakur-rh requested a review from a team as a code owner October 29, 2026 05:26

jack-berg reviewed Nov 3, 2026

View reviewed changes

ash-thakur-rh added 2 commits November 5, 2026 14:29

feat: fixes as per suggestions

bf33c6f

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

feat: update to move mapper from internal package

8fcb020

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

otelbot Bot added the api-change Changes to public API surface area label Nov 5, 2026

ash-thakur-rh added 2 commits November 5, 2026 15:54

feat: update to move mapper from internal package

fd8e4ac

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

feat: minor fixes

657ee4a

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

otelbot Bot removed the api-change Changes to public API surface area label Nov 5, 2026

feat: apply same logic to parser autoconfigure

cc4a52b

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

This comment has been minimized.

Sign in to view

Merge branch 'main' into features/fe-config-spi

82dfaa7

jack-berg reviewed Nov 11, 2026

View reviewed changes

ash-thakur-rh added 3 commits November 12, 2026 17:40

feat: updates as per code review

957940c

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

feat: updates for tests

77de82f

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

feat: update readme doc

c2ebc56

Signed-off-by: Ashish Thakur <ashishth@redhat.com>

jack-berg added 2 commits November 12, 2026 16:42

Final tweaks

a72d54f

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

f584b4a

…y-java into features/fe-config-spi

jack-berg approved these changes Nov 12, 2026

View reviewed changes

jack-berg enabled auto-merge (squash) November 12, 2026 22:49

jack-berg disabled auto-merge November 12, 2026 22:49

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

f283bcd

…y-java into features/fe-config-spi

jack-berg enabled auto-merge (squash) November 13, 2026 00:01

jack-berg merged commit b11bb9c into open-telemetry:main Nov 13, 2026
73 of 78 checks passed

Conversation

ash-thakur-rh commented Oct 28, 2026 • edited by jack-berg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Uh oh!

linux-foundation-easycla Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opentelemetry-pr-dashboard Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request dashboard status

Uh oh!

codecov Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ash-thakur-rh commented Oct 28, 2026 • edited by linux-foundation-easycla Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ash-thakur-rh commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ash-thakur-rh commented Nov 11, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Nov 11, 2026

Uh oh!

Uh oh!

jack-berg Nov 11, 2026

Choose a reason for hiding this comment

Uh oh!

ash-thakur-rh Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ash-thakur-rh commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ash-thakur-rh commented Nov 12, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Nov 12, 2026

Uh oh!

jack-berg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

otelbot Bot commented Nov 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ash-thakur-rh commented Oct 28, 2026 •

edited by jack-berg

Loading

linux-foundation-easycla Bot commented Oct 28, 2026 •

edited

Loading

opentelemetry-pr-dashboard Bot commented Oct 28, 2026 •

edited

Loading

codecov Bot commented Oct 28, 2026 •

edited

Loading

ash-thakur-rh commented Oct 28, 2026 •

edited by linux-foundation-easycla Bot

Loading

ash-thakur-rh commented Nov 5, 2026 •

edited

Loading

ash-thakur-rh commented Nov 12, 2026 •

edited

Loading