Set original_payload_format to "jfr" in the JFR export example - #8809
Open
thswlsqls wants to merge 1 commit into
Open
Set original_payload_format to "jfr" in the JFR export example#8809thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8809 +/- ##
============================================
- Coverage 91.28% 91.27% -0.02%
+ Complexity 10528 10526 -2
============================================
Files 1008 1008
Lines 28465 28465
Branches 3617 3617
============================================
- Hits 25984 25981 -3
Misses 1685 1685
- Partials 796 799 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-12 12:36 UTC Review the latest changes. Status above doesn't look right?
|
thswlsqls
marked this pull request as ready for review
September 12, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8807
Description
JfrExportExample.convertJfrFile()attaches the raw.jfrfile bytes asoriginalPayloadbut passes the literal"format"asoriginalPayloadFormat; this changes it to"jfr".ProfileData.getOriginalPayloadFormat()Javadoc requires the field whenoriginal_payloadis present and defers to semantic conventions for its values; theprofiles.protocomment onoriginal_payload_formatgivesjfras its example, and the specification profiles README listspprof,jfrandlinux_perfas known values."format"is the placeholder from the exporter test fixtureFakeTelemetryUtil, unchanged since the module was added in profiles: split out SDK and JFR shim modules #8207.ValueTypeData.create(0, 0)placeholder in the same call but left this argument.Testing done
./gradlew :opentelemetry-jfr-profiles-shim:check— BUILD SUCCESSFUL (compileJava, checkstyleMain and spotlessCheck passed;testreported NO-SOURCE).