Implementing minimum_severity and trace_based attributes for LoggerConfig#4131
Open
om7057 wants to merge 2 commits into
Open
Implementing minimum_severity and trace_based attributes for LoggerConfig#4131om7057 wants to merge 2 commits into
om7057 wants to merge 2 commits into
Conversation
… for LoggerConfig
Author
|
Hi @marcalff could you please review the changes in this PR, and assign the issue? |
Contributor
|
Can you update CHANGELOG.md? |
Author
Yes, I've updated the CHANGELOG.md file as well. Could you please review all my changes and confirm whether this PR resolves the issue #4130 ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4131 +/- ##
==========================================
+ Coverage 81.94% 82.02% +0.09%
==========================================
Files 385 385
Lines 16067 16071 +4
==========================================
+ Hits 13164 13181 +17
+ Misses 2903 2890 -13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4130
Changes
Description
Implements the missing
minimum_severityandtrace_basedattributes forLoggerConfigin the declarative configuration spec.Previously,
LoggerConfigConfigurationonly had anenabledboolean field. This PR adds:minimum_severity(type:SeverityNumber, default:trace) — allows filtering log records by severity leveltrace_based(type:bool, default:false) — enables/disables trace-based log filteringThese attributes align with the OpenTelemetry specification for logger configuration and enable users to control logging behavior via YAML configuration.
Example YAML usage:
For significant contributions, please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes