Conversation
|
Add Value::toStyledString(const StreamWriterBuilder&) and Value::toStyledString(unsigned int, PrecisionType) while keeping the existing no-argument overload for ABI compatibility. Skip the leading newline when the builder suppresses comments. Fixes open-source-parsers#1616 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Thanks for the review! I've rebased onto the latest master and squashed everything into a single commit (4c61985). All five points are addressed:
All 134 unit tests and the reader/writer tests pass locally (MSVC), and the changed files are clang-format clean. |
YackerYan
marked this pull request as draft
September 29, 2026 07:22
YackerYan
marked this pull request as ready for review
September 29, 2026 07:24
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1616
Adds two
Json::Value::toStyledStringoverloads:toStyledString(const StreamWriterBuilder& builder): serialize using any builder settings (indentation, comment style, precision, etc.).toStyledString(unsigned int precision, PrecisionType precisionType): shorthand for controlling floating-point output, in either decimal places or significant digits. Precision above 17 is capped, same asStreamWriterBuilder.Notes:
toStyledString()is unchanged, so the exported symbol and ABI are preserved.commentStyleto"None", the leading newline normally added for acommentBeforecomment is omitted.ValueTest/toStyledStringWithBuilderandValueTest/toStyledStringWithPrecision.