fix the problems with project sharing#478
Draft
josihoppe wants to merge 8 commits into
Draft
Conversation
josihoppe
commented
May 26, 2026
josihoppe
commented
- add decorator to use in views instead of repeating checks for user / viewer
- check the problems described in:
- Issue 464
- this comment
- adjust sharing rights for these problems
…rojects for simpler views
paulapreuss
reviewed
May 28, 2026
| @login_required | ||
| @json_view | ||
| @require_http_methods(["GET"]) | ||
| @viewer_has_view_rights |
There was a problem hiding this comment.
is viewer_has_view_rights the same (from a permissions perspective) as user.has_read_rights? If so, I find it confusing to have the two terminologies and would rename the decorator to user_has_read_rights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.