Fixes #33595: run the jest coverage job on core-components changes - #33596
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
The app compiles against ui-core-components through a yarn `link:`, so a change confined to that package changes what the app's unit tests run — while matching none of the paths the coverage filter watches. The job is skipped, the pass-on-skip gates go green, and the breakage only surfaces once it is on main and blocking the merge queue. Watch the same core-components paths ui-checkstyle already does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
6d057c6 to
3831d36
Compare
Code Review ✅ Approved🟢 Low risk Adds OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
✅ Playwright Results — workflow succeededValidated commit ✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 59m 10s ⏱️ Max setup 4m 34s · max shard execution 17m 49s · max shard-job elapsed before upload 20m 57s · reporting 5s 🌐 227.40 requests/attempt · 2.24 app boots/UI scenario · 36.58% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Fixes #33595
What
Adds the
openmetadata-ui-core-componentspaths to thedorny/paths-filterthat gatesui-coverage-testsin.github/workflows/yarn-coverage.yml.Why
The app compiles against
@openmetadata/ui-core-componentsvia a yarnlink:dependency, so a change confined to that package changes what the app's unit tests execute — while matching none of theopenmetadata-ui/**paths the filter watches. The job is skipped, andui-coverage/ui-sonar-gateboth pass-on-skip by design, so the PR goes green having never run the suite.That is how #33591 happened: #33163 touched only core-components, passed every check, and broke three unit tests on
main, blocking every entry in the merge queue.ui-checkstyle.ymlalready watchesopenmetadata-ui-core-components/src/main/resources/ui/**; this brings the coverage workflow in line.How
Four paths added to the
uifilter —src/**,package.json,yarn.lock,vite.config.ts— matching the setui-checkstyleuses for the same package.No change to the job itself: it runs
yarn installin the app directory, whosepreinstallinstalls and builds core-components, so the suite already runs against the PR's version of the library.Trade-off
Core-components PRs now pay the full Jest + Sonar run. That is the intent — it is the only check that exercises the library against its consumer.
Testing
YAML parses; the diff is filter paths only, so the first core-components PR after this merges is the real verification. Companion to #33592, which fixes the tests that are currently blocking the queue.
🤖 Generated with Claude Code
The PR appears safe to merge; the added filters cover the core-components inputs that directly determine the linked package build exercised by the UI test suite.
Summary
This PR broadens the UI coverage workflow’s path filter so changes to the linked core-components package trigger the existing Jest coverage and Sonar jobs.
Reviews (1) · Last reviewed commit: "ci: run the jest coverage job on core-co..."