fix(ui): theme Test Cases list for dark mode - #33583
shah-harshit wants to merge 1 commit into
Conversation
The dimension-count chip in the AI-mode Test Cases list used the raw palette class tw:bg-blue-50, which does not invert in dark mode, so its light-blue background stayed fixed while tw:text-primary flipped to a light foreground — light-on-light, unreadable in dark. Swap to tw:bg-utility-blue-50, which auto-inverts (light blue tint in light, dark blue in dark) per colors.md §2.7, keeping text-primary readable in both themes. Light mode is unchanged. The rest of the Test Cases list (table header, filters, table shell) was already on adaptive semantic tokens. Refs open-metadata/openmetadata-collate#6534 open-metadata/openmetadata-collate#6459 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ Approved🟢 Low risk Fixes dark-mode readability of the dimension-count chip in the Test Cases list by replacing the raw palette class OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
🔴 Playwright Results — workflow failedValidated commit ✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky ⚙️ No test failures. This run failed in CI infrastructure or reporting (see Pipeline and setup failures), not because of your changes — no test action needed from you. Pipeline and setup failures (6)
Performance⚪ Performance metrics unavailable; see the CI and reporting failures above.
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes
Dark-mode coverage for the AI-mode Test Cases list route (workstream open-metadata/openmetadata-collate#6459, ticket open-metadata/openmetadata-collate#6534).
The AI-mode Test Cases route (
components/observability/DataQuality/TestCases), its table header, filters, and table shell already use adaptive semantic tokens. The single dark-mode gap was the dimension-count chip inDataQualityTab, which used the raw palette classtw:bg-blue-50. Raw palette classes do not invert in dark mode, so the light-blue background stayed fixed whiletw:text-primaryflipped to a light foreground → light-on-light, unreadable in dark.Change
tw:bg-blue-50→tw:bg-utility-blue-50(auto-inverts percolors.md§2.7). Light mode unchanged.Type of change
Checklist
git diff --checkclean; prettier clean🤖 Generated with Claude Code
The PR appears safe to merge because the changed class is an established adaptive token and introduces no functional regression.
Summary
This PR fixes the dimension-count chip’s dark-mode contrast by replacing a fixed blue palette background with the adaptive
utility-blue-50semantic token..dark-mode.Reviews (1) · Last reviewed commit: "fix(ui): theme Test Cases list dimension..."