Skip to content

fix(ui): theme Test Cases list for dark mode - #33583

Closed
shah-harshit wants to merge 1 commit into
mainfrom
6534-test-cases-list-dark
Closed

shah-harshit wants to merge 1 commit into
mainfrom
6534-test-cases-list-dark

Conversation

@shah-harshit

@shah-harshit shah-harshit commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Dark-mode coverage for the AI-mode Test Cases list route (workstream open-metadata/openmetadata-collate#6459, ticket open-metadata/openmetadata-collate#6534).

The AI-mode Test Cases route (components/observability/DataQuality/TestCases), its table header, filters, and table shell already use adaptive semantic tokens. The single dark-mode gap was the dimension-count chip in DataQualityTab, which used the raw palette class tw:bg-blue-50. Raw palette classes do not invert in dark mode, so the light-blue background stayed fixed while tw:text-primary flipped to a light foreground → light-on-light, unreadable in dark.

Change

  • tw:bg-blue-50tw:bg-utility-blue-50 (auto-inverts per colors.md §2.7). Light mode unchanged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • git diff --check clean; prettier clean
  • Visual light/dark QA of the AI Test Cases list — pending (static-only change)

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the changed class is an established adaptive token and introduces no functional regression.

Summary

This PR fixes the dimension-count chip’s dark-mode contrast by replacing a fixed blue palette background with the adaptive utility-blue-50 semantic token.

  • Preserves the existing light-mode appearance.
  • Allows the chip background to adapt under .dark-mode.
  • Makes no behavioral, data-flow, or API changes.

Reviews (1) · Last reviewed commit: "fix(ui): theme Test Cases list dimension..."

The dimension-count chip in the AI-mode Test Cases list used the raw
palette class tw:bg-blue-50, which does not invert in dark mode, so its
light-blue background stayed fixed while tw:text-primary flipped to a
light foreground — light-on-light, unreadable in dark.

Swap to tw:bg-utility-blue-50, which auto-inverts (light blue tint in
light, dark blue in dark) per colors.md §2.7, keeping text-primary
readable in both themes. Light mode is unchanged.

The rest of the Test Cases list (table header, filters, table shell) was
already on adaptive semantic tokens.

Refs open-metadata/openmetadata-collate#6534 open-metadata/openmetadata-collate#6459

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot

gitar-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk

Fixes dark-mode readability of the dimension-count chip in the Test Cases list by replacing the raw palette class tw:bg-blue-50 with the semantic token tw:bg-utility-blue-50, which auto-inverts in dark mode. No issues found.

Review coverage

Rules No rules evaluated

Functional validation Not enabled · Set up

Auto-approval Not enabled · Set up

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Playwright Results — workflow failed

Validated commit b4aa8483729b23139ed42f71cf2c3c78da4e5245 in Playwright run 35355874797, attempt 1.

✅ 0 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

⚙️ No test failures. This run failed in CI infrastructure or reporting (see Pipeline and setup failures), not because of your changes — no test action needed from you.

Pipeline and setup failures (6)

  • The build job finished with status failure.
  • Duration-aware shard planning finished with status skipped.
  • Fixture cache restoration finished with status skipped.
  • Seeded fixture preparation finished with status skipped.
  • The Playwright shard matrix was unexpectedly skipped.
  • No expected Playwright shards were declared.

Performance

⚪ Performance metrics unavailable; see the CI and reporting failures above.

Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@shah-harshit

Copy link
Copy Markdown
Contributor Author

Superseded by #33586, which combines the full Data Quality & Observability dark-mode workstream (#6459) into a single PR. Commits carried over via cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant