Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved 1 closed / 1 findings🟢 Low risk Updates the automated tag icon to match design standards. Consider removing the hardcoded ✅ 1 closedClosed: Quality: Hardcoded stroke="currentColor" on paths ignores color prop
OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
✅ Playwright Results — workflow succeededValidated commit ✅ 46 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 37m 38s ⏱️ Max setup 2m 58s · max shard execution 7m 40s · max shard-job elapsed before upload 11m 6s · reporting 3s 🌐 145.67 requests/attempt · 1.27 app boots/UI scenario · 0.00% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes:
Fixes #
I worked on ... because ...
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.The PR appears safe to merge, with the SVG source, generated React component, and Storybook example remaining consistent.
Summary
This PR updates the automated-classification tag icon to the current design and adds the tag to the Entity Tags Storybook variants.
AutomatedTagReact component while preserving inherited color support.AutoClassificationTagexample to the existing Entity Tags story.Reviews (1) · Last reviewed commit: "Updated the automated tag icon as per de..."