Skip to content

Updated the automated tag icon as per design standard - #33577

Open
Rohit0301 wants to merge 1 commit into
mainfrom
new-automated-tag
Open

Rohit0301 wants to merge 1 commit into
mainfrom
new-automated-tag

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

Screenshot 2026-09-18 at 5 06 49 PM

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the SVG source, generated React component, and Storybook example remaining consistent.

Summary

This PR updates the automated-classification tag icon to the current design and adds the tag to the Entity Tags Storybook variants.

  • Replaces the standalone automated-tag SVG paths.
  • Synchronizes the generated AutomatedTag React component while preserving inherited color support.
  • Adds an AutoClassificationTag example to the existing Entity Tags story.

Reviews (1) · Last reviewed commit: "Updated the automated tag icon as per de..."

@Rohit0301 Rohit0301 self-assigned this Sep 18, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Sep 18, 2026
@gitar-bot

gitar-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 closed / 1 findings

🟢 Low risk

Updates the automated tag icon to match design standards. Consider removing the hardcoded stroke="currentColor" on individual <path> elements in AutomatedTag.tsx so the component's color prop is properly honored instead of being silently overridden.

✅ 1 closed
Closed: Quality: Hardcoded stroke="currentColor" on paths ignores color prop

📄 openmetadata-ui-core-components/src/main/resources/ui/src/icons/AutomatedTag.tsx:37 📄 openmetadata-ui-core-components/src/main/resources/ui/src/icons/AutomatedTag.tsx:42 📄 openmetadata-ui-core-components/src/main/resources/ui/src/icons/AutomatedTag.tsx:47
Each new <path> hardcodes stroke="currentColor", which overrides the SVG-level stroke={color} derived from the component's color prop. As a result, passing a color prop to AutomatedTag has no visible effect—the strokes always resolve to currentColor. Current call sites rely on the CSS-color default so nothing breaks today, but the public color API is now silently non-functional. Drop the per-path stroke (or set it to color) so the prop is honored.

Review coverage

Rules No rules evaluated

Functional validation Not enabled · Set up

Auto-approval Not enabled · Set up

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 65d0e7a5f38639717dfd4d9b4ea981dc485d9fc0 in Playwright run 35340789287, attempt 1.

✅ 46 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 37m 38s

⏱️ Max setup 2m 58s · max shard execution 7m 40s · max shard-job elapsed before upload 11m 6s · reporting 3s

🌐 145.67 requests/attempt · 1.27 app boots/UI scenario · 0.00% common-shard skew

Optimization targets still in progress:

  • Application boot ratio was 1.27 per UI scenario (61 boots / 48 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 46 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant