Conversation
entity-data.setup.ts: pin SearchIndexingApplication's schedule to None. Its weekly rebuild could otherwise fire partway through a shard and rewrite the shared search results specs had already asserted on. KnowledgeGraph.spec.ts: poll a SPARQL ASK for the schema->table edge before the suite runs. The RDF projection is asynchronous, so beforeAll could hand the suite a graph that had not seen the table yet. afterAction() also moves into a finally so a setup failure stops leaking the API context. GlobalPageSize.spec.ts: only click the Records button when the option is not already visible. The retry block clicked unconditionally, so a retry with the menu already open closed it and failed the next assertion; the clicks are now bounded so the outer retry can reopen it if the summary panel resizes the page. LineageFilters.spec.ts: click the option before asserting the lineage node exists, rather than the other way round. Each is removed at its source rather than absorbed by a longer timeout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
harshach
requested review from
ShaileshParmar11,
chirag-madlani and
karanh37
as code owners
September 18, 2026 00:58
29 tasks
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #33549. Salvaged from the closed PR #33248 (tracking: #33528).
Four Playwright flake sources, each removed at its source rather than absorbed by a longer timeout.
1. A weekly reindex can rewrite shared search results mid-shard.
entity-data.setup.tscreatesthe entities every spec in the shard shares, but nothing pinned
SearchIndexingApplication'sschedule. If its weekly rebuild fired partway through a shard, search results changed underneath
specs that had already asserted on them. The setup now patches
appSchedule.scheduleTimelinetoNoneand asserts the patch took.2.
KnowledgeGraph.spec.tsstarted before the RDF projection caught up.beforeAllcreated atable and proceeded immediately; the projection is asynchronous, so the first assertions could run
against a graph that had not seen the table. It now polls a SPARQL
ASKfor the schema→table edgewith a 60 s budget.
afterAction()also moves into afinally, so a failure during setup stopsleaking the API context.
3.
GlobalPageSize.spec.tsreopened a popover it had already opened. The retry block clicked the"Records" button unconditionally, so on a retry where the menu was already open the click closed it
and the next assertion failed. It now clicks only when the option is not already visible, and the
clicks are bounded so the outer
expect(async () => …)retry can reopen the popover if the summarypanel resizes the page mid-check.
4.
LineageFilters.spec.tsasserted a node existed before selecting it. The visibility assertionfor
lineage-node-${topicFqn}ran before the click that adds the node. Order swapped.Type of change:
High-level design:
N/A — four independent test-stability fixes, 54 lines total.
Tests:
Use cases covered
Unit tests
Not applicable — these are Playwright specs.
Backend integration tests
Not applicable — no product code changes.
Ingestion integration tests
Not applicable.
Playwright (UI) tests
This PR is the Playwright change:
entity-data.setup.ts,KnowledgeGraph.spec.ts,GlobalPageSize.spec.ts,LineageFilters.spec.ts.Manual testing performed
yarn lint:baseon all four files — 0 errors (4 pre-existingrequire-aggregation-wait-helperwarnings inLineageFilters.spec.tsat lines 503/625/705/785,none at the changed line 1037).
npx prettier --checkon all four — "All matched files use Prettier code style!".locally — stating that plainly rather than implying I ran them here.
UI screen recording / screenshots:
Not applicable — no product UI change.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #33549.🤖 Generated with Claude Code
The PR appears safe to merge, with no outstanding correctness or repository-rule issues.
Summary
This PR removes four Playwright flake sources by disabling scheduled search reindexing during shared fixture setup, waiting for RDF projection readiness, making the page-size popover interaction retry-safe, and correcting lineage node selection order.
Reviews (3) · Last reviewed commit: "Merge remote-tracking branch 'origin/har..."