fix(playwright): re-trigger when a test-suite pipeline run never leaves the queue

[ShaileshParmar11]

Follow-up to #30789 (already merged).

Problem

IncidentManager tests that keep a real pipeline (the main beforeAll and the re-run tests) intermittently fail in CI with Received: "queued" → 300s timeout. Confirmed from a merge-queue run's Airflow diagnostics: the freshly-deployed DAG isn't serialized when OM triggers it (AirflowRESTClient: 404 "DAG … not found"), so the DagRun executes empty (run_duration=0.026s, no task) and writes no status. In the trace this shows as a brief queued status followed by an empty pipelineStatus.

Why the existing recovery missed it

waitForNewRunToAppear re-triggers only when no run appears — but the empty-DAG race produces a transient queued run, and the check counted any run as "materialized", so it skipped the re-trigger. The run then vanished and the success poll waited out the full timeout.

Fix

Require the run to have actually left the queue before counting it:

if (
  run &&
  isNewRun(run) &&
  run.pipelineState !== undefined &&
  run.pipelineState !== PipelineState.Queued
) {
  return true;
}

A real run leaves queued within seconds; the empty-DAG run never does. So the transient queued no longer short-circuits the existing re-trigger loop, which fires and triggers again against the now-serialized DAG. If even that fails 3× (pathological saturation) it throws a clear error instead of the silent 300s hang.

Scope / validation

• One-line-ish change to the shared helper; ESLint/Prettier/tsc clean.
• Behavioral validation is via CI under load — the race is an Airflow-3.x, load-dependent timing bug and can't be reproduced on a non-Airflow local stack. The change only makes the appearance check stricter and reuses the already-shipped re-trigger path, so it's low-risk.
• Note: the durable fix for the UI tests is seeding incidents (landed for pagination in test(playwright): seed IncidentManager pagination incidents instead of running a pipeline #30789; lifecycle/tab/filters is a further follow-up). This patch hardens the tests that genuinely keep a pipeline. The underlying product race (deploy returns before the DAG is serialized) is a separate backend concern.

🤖 Generated with Claude Code

[github-actions]

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

• No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

[gitar-bot]

Code Review ✅ Approved

Updates the Playwright test helper to check that pipeline runs actually leave the queued state before considering them materialized, preventing 300-second timeouts caused by empty DAG runs. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source}

[Copilot]

Pull request overview

This PR hardens the Playwright IncidentManager pipeline-trigger helper against an Airflow race where a freshly deployed DAG can briefly report a queued run and then produce no durable pipelineStatus, leading to a full timeout wait.

Changes:

• Tightens the “new run appeared” check to require the latest run to be both new and not in PipelineState.Queued.
• Expands inline documentation to explain the transient-queued / empty-DAG failure mode and why it previously bypassed the re-trigger loop.

[github-actions]

✅ Playwright Results — workflow succeeded

Validated commit 6a78fbffb33d8004db7fdbff6afa6375a6651c42 in Playwright run 30814215242, attempt 1.

✅ 768 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 3 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 52m 7s

⏱️ Max setup 2m 53s · max shard execution 18m 0s · max shard-job elapsed before upload 21m 25s · reporting 4s

🌐 200.81 requests/attempt · 2.65 app boots/UI scenario · 11.57% common-shard skew

Optimization targets still in progress:

• Browser traffic was 200.81 requests per attempt (convergence target: fewer than 200).
• Application boot ratio was 2.65 per UI scenario (2121 boots / 800 scenarios; convergence target: at most 1).

Shard	Passed	Failed	Flaky	Skipped	Lifecycle failed	Lifecycle flaky
✅ Shard chromium-01	124	0	0	3	0	0
✅ Shard chromium-02	140	0	0	0	0	0
✅ Shard chromium-03	156	0	0	0	0	0
✅ Shard chromium-04	140	0	0	0	0	0
✅ Shard data-asset-rules-01	61	0	0	0	0	0
✅ Shard domain-isolation-01	14	0	0	0	0	0
✅ Shard global-state-01	34	0	0	0	0	0
✅ Shard import-export-01	26	0	0	0	0	0
✅ Shard ingestion-01	29	0	0	0	0	0
✅ Shard reindex-01	5	0	0	0	0	0
✅ Shard search-01	10	0	0	0	0	0
✅ Shard search-rbac-01	29	0	0	0	0	0

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace