Skip to content

fix(dar): format Data Access Request expiry as a date in the task tab - #30873

Queued
anuj-kumary wants to merge 2 commits into
open-metadata:mainfrom
anuj-kumary:fix/dar-task-expiry-date-format
Queued

fix(dar): format Data Access Request expiry as a date in the task tab#30873
anuj-kumary wants to merge 2 commits into
open-metadata:mainfrom
anuj-kumary:fix/dar-task-expiry-date-format

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Aug 3, 2026

Copy link
Copy Markdown
Member

What & why

On the entity Activity Feed & Tasks tab, a Data Access Request's Expiration Date was shown as a raw epoch number (e.g. 1786699421850), while the DAR detail drawer showed the same value as a friendly date. The task tab renders the DAR payload generically via TaskPayloadSchemaFields, applying per-field DAR_FIELD_FORMATTERS — that map formatted duration but had no entry for expirationDate, so the number fell through unformatted.

How

Add an expirationDate entry to DAR_FIELD_FORMATTERS that reuses the existing shared formatDate util (the same one the DAR detail drawer uses), so both surfaces render the expiry consistently.

Issue -
Screenshot 2026-08-03 at 8 01 04 PM

Testing

  • Open a table → Activity Feed & Tasks → a Data Access Request task: the Expiration Date now renders as a date, matching the DAR detail drawer.
  • Prettier/tsc clean.

🤖 Generated with Claude Code

The Activity Feed / Task tab renders the DAR payload via TaskPayloadSchemaFields
using DAR_FIELD_FORMATTERS, which formatted `duration` but not `expirationDate`
— so the expiry showed as a raw epoch number (e.g. 1786699421850) while the DAR
detail drawer showed it as a friendly date. Add an `expirationDate` formatter
that reuses the shared `formatDate` util so both surfaces are consistent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@anuj-kumary
anuj-kumary requested a review from a team as a code owner August 3, 2026 12:04
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary self-assigned this Aug 3, 2026
@anuj-kumary anuj-kumary added safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check To release Will cherry-pick this PR into the release branch labels Aug 3, 2026
@gitar-bot

gitar-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Formats Data Access Request expiry values as friendly dates in the task tab using the existing shared formatDate utility. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

@github-actions github-actions Bot removed the safe to test Add this label to run secure Github workflows on PRs label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ UI Checkstyle passed — lint findings in changed files

🔍 ESLint findings in this PR's files — ESLint report could not be read — see the job log.

Errors block the build. Warnings do not yet — they are rules whose backlog is still
being worked down, listed so this PR does not add to it. See docs/ui-code-quality-gate.md.

No machine-readable report was produced.


Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
66% (77626/117599) 49.96% (46837/93732) 51.14% (14079/27527)

@anuj-kumary
anuj-kumary enabled auto-merge August 3, 2026 14:43
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants