test(mcp): assert public clients get no client secret (#28568)#28758
test(mcp): assert public clients get no client secret (#28568)#28758Vishnuujain wants to merge 2 commits into
Conversation
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
🔴 Playwright Results — 2 failure(s), 15 flaky✅ 4261 passed · ❌ 2 failed · 🟡 15 flaky · ⏭️ 88 skipped
Genuine Failures (failed on all attempts)❌
|
Code Review ✅ ApprovedRegression tests verify that public clients correctly receive no client secret while maintaining existing behavior for confidential clients. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Adds regression tests for #28552 — public clients (
token_endpoint_auth_method=none) must not be issued aclient_secret.testPublicClient_none_issuesNoSecret: public client gets no secret (fails against pre-fix code).client_secret_post/basic/default) still get a secret with no expiry.Closes #28568