Backport #28309 to 1.12.10#28754
Draft
ayush-shah wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
Ingestion
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #28309 to the
1.12.10release branch.This applies the reviewed Kafka Avro sample-data fix so already-deserialized Avro values from
DeserializingConsumerare not deserialized a second time, and includes the regression coverage from the original PR.Cherry-picked commits:
Validation:
git diff --check origin/1.12.10..codex/backport-28309-1.12.10python3.11 -m py_compile ingestion/src/metadata/ingestion/source/messaging/common_broker_source.py ingestion/tests/unit/source/messaging/test_common_broker_source.pyNote: targeted pytest could not be completed locally. The global pytest environment is missing
sqlalchemy, anduv run --project ingestion --python 3.11 --extra test-unit --extra kafka pytest ...failed during dependency resolution because the branch extras pull incompatibleallandgreat-expectationsconstraints.