You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: adjust id to accountId for easy understanding - #16
The AWS connector and connector SDK now use accountId instead of id for account identifiers. Account creation returns the ARN as accountId; account-action and entitlement handlers accept it. Related tests and fixtures use the updated field.
Changes: Account identifier contract and usage
Layer / File(s)
Summary
Define and produce accountId packages/connector-sdk/lib/iga/connector/validation-schema/*, connectors/aws/src/account-actions/create.ts, packages/connector-sdk/lib/iga/dispatcher.test.ts, connectors/aws/e2e/account-acctions.create.test.ts, connectors/aws/src/utils/arn.ts, .changeset/mighty-bikes-divide.md
Account-action and entitlement schemas use accountId. Account creation returns the ARN under that field. Dispatcher and creation tests use the updated identifier.
Use accountId in account and entitlement actions connectors/aws/src/account-actions/*, connectors/aws/src/entitlements/iam-user-groups/*, connectors/aws/e2e/account-actions.lifecycle.test.ts, connectors/aws/e2e/entitlements.test.ts
Account-action and IAM user-group handlers use input.accountId. Lifecycle and entitlement tests pass the created accountId to subsequent actions.
open-iga/plugins#14: This PR also changes the account identifier contract in the account-action schema, create handler, dispatcher tests, and related end-to-end tests.
Merge Risk: Minimal · up to d2889
The accountId rename is consistent across the inspected implementation and tests. Adding an ARN assertion would improve regression coverage, but no concrete merge-blocking failure was established.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
accountIdacross account creation, lifecycle actions, entitlement operations, and account listings.