Skip to content

chore: adjust id to accountId for easy understanding - #16

Merged
Prasanna-ramesh merged 3 commits into
mainfrom
chore/rename-account-id
Nov 4, 2026
Merged

Prasanna-ramesh merged 3 commits into
mainfrom
chore/rename-account-id

Conversation

@Prasanna-ramesh

@Prasanna-ramesh Prasanna-ramesh commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Standardized AWS account identifiers as accountId across account creation, lifecycle actions, entitlement operations, and account listings.
    • Updated the related checks to reflect the consistent identifier format.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The AWS connector and connector SDK now use accountId instead of id for account identifiers. Account creation returns the ARN as accountId; account-action and entitlement handlers accept it. Related tests and fixtures use the updated field.

Changes: Account identifier contract and usage

Layer / File(s) Summary
Define and produce accountId
packages/connector-sdk/lib/iga/connector/validation-schema/*, connectors/aws/src/account-actions/create.ts, packages/connector-sdk/lib/iga/dispatcher.test.ts, connectors/aws/e2e/account-acctions.create.test.ts, connectors/aws/src/utils/arn.ts, .changeset/mighty-bikes-divide.md
Account-action and entitlement schemas use accountId. Account creation returns the ARN under that field. Dispatcher and creation tests use the updated identifier.
Use accountId in account and entitlement actions
connectors/aws/src/account-actions/*, connectors/aws/src/entitlements/iam-user-groups/*, connectors/aws/e2e/account-actions.lifecycle.test.ts, connectors/aws/e2e/entitlements.test.ts
Account-action and IAM user-group handlers use input.accountId. Lifecycle and entitlement tests pass the created accountId to subsequent actions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related PRs

  • open-iga/plugins#14: This PR also changes the account identifier contract in the account-action schema, create handler, dispatcher tests, and related end-to-end tests.
Merge Risk: Minimal · up to d2889

The accountId rename is consistent across the inspected implementation and tests. Adding an ARN assertion would improve regression coverage, but no concrete merge-blocking failure was established.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Prasanna-ramesh
Prasanna-ramesh merged commit 63552d7 into main Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant