feat(flagd-core): update fractional operator to CBOR encoding (v3) - #415
Draft
m-olko wants to merge 1 commit into
Draft
feat(flagd-core): update fractional operator to CBOR encoding (v3)#415m-olko wants to merge 1 commit into
m-olko wants to merge 1 commit into
Conversation
Update fractional bucketing in openfeature-flagd-core to use canonical CBOR encoding and unsigned 32-bit MurmurHash3 per the latest flagd specification. - Implement number normalization for float/int consistency per specification - Support non-string targeting keys and null bucketing keys returning None - Use [flagKey, targetingKey] CBOR array for shorthand bucketing syntax - Update flagd-testbed submodule to v3.10.1 and select @fractional-v3 tests - Add unit tests for null handling, zero equivalence, float equivalence, and ordering Signed-off-by: Marcin Olko <molko@google.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 95.64% 93.57% -2.08%
==========================================
Files 24 31 +7
Lines 1057 1089 +32
==========================================
+ Hits 1011 1019 +8
- Misses 46 70 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Update fractional bucketing in openfeature-flagd-core to use canonical CBOR encoding and unsigned 32-bit MurmurHash3 per the latest flagd specification.
Implement number normalization for float/int consistency per specification
Support non-string targeting keys and null bucketing keys returning None
Use [flagKey, targetingKey] CBOR array for shorthand bucketing syntax
Update flagd-testbed submodule to v3.10.1 and select @fractional-v3 tests
Add unit tests for null handling, zero equivalence, float equivalence, and ordering
Related Issues
Fixes #324