Skip to content

Added new check and fixed files with it#116

Merged
m-olko merged 2 commits into
mainfrom
misc_include_cleaner_check
Jun 18, 2026
Merged

Added new check and fixed files with it#116
m-olko merged 2 commits into
mainfrom
misc_include_cleaner_check

Conversation

@m-olko

@m-olko m-olko commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR

Adds new misc-include-cleaner check for clang-tidy, and fixes all files that violated it earlier

Signed-off-by: Marcin Olko <molko@google.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the misc-include-cleaner check in .clang-tidy and cleans up header includes across various source files in the flagd provider. It also modifies numeric.cpp to use nums_res.value() instead of (*nums_res). The review feedback consistently points out that using .value() is less idiomatic, inconsistent with the rest of the file, and introduces unnecessary exception-throwing overhead since the status has already been checked. It is recommended to revert these changes to use the dereference operator * instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Comment thread providers/flagd/src/evaluator/json_logic/numeric.cpp
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko requested a review from oxddr June 18, 2026 08:55
@m-olko m-olko merged commit 53b4cb6 into main Jun 18, 2026
3 checks passed
@m-olko m-olko deleted the misc_include_cleaner_check branch June 18, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants