Added new check and fixed files with it#116
Conversation
Signed-off-by: Marcin Olko <molko@google.com>
There was a problem hiding this comment.
Code Review
This pull request enables the misc-include-cleaner check in .clang-tidy and cleans up header includes across various source files in the flagd provider. It also modifies numeric.cpp to use nums_res.value() instead of (*nums_res). The review feedback consistently points out that using .value() is less idiomatic, inconsistent with the rest of the file, and introduces unnecessary exception-throwing overhead since the status has already been checked. It is recommended to revert these changes to use the dereference operator * instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Marcin Olko <molko@google.com>
This PR
Adds new
misc-include-cleanercheck for clang-tidy, and fixes all files that violated it earlier