perf(layout): stabilize AppShell stream-event Set state to prevent cascade re-renders#610
Closed
HUQIANTAO wants to merge 1 commit into
Closed
perf(layout): stabilize AppShell stream-event Set state to prevent cascade re-renders#610HUQIANTAO wants to merge 1 commit into
HUQIANTAO wants to merge 1 commit into
Conversation
The 'stream-session-event' handler was creating fresh Set objects on every ~100ms stream tick and passing them to useState unconditionally. These Sets flow into panelContextValue (a new object reference every render), causing ALL usePanel() consumers (UnifiedTopBar, ChatListPanel, FileTreePanel, etc.) to re-render on every streaming text chunk — even though the set of active sessions rarely changes mid-stream. Use functional updaters with identity checks: - activeStreamingSessions: compare size + contents against previous; return the same Set reference when identical - pendingApprovalSessionIds: same comparison pattern When the set content hasn't changed (the common case — usually the same single session the whole time), the state update is skipped entirely, preventing the cascade re-render through panelContextValue.
|
Someone is attempting to deploy a commit to the op7418's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Closing this PR as part of a batch of low-signal/bulk-generated submissions from the same account. Please open one focused PR with a clear problem statement, implementation rationale, and tests if this change is intentional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stream-session-event handler was creating fresh Set objects on every ~100ms tick and passing them to useState unconditionally. These Sets flow into panelContextValue, causing ALL usePanel() consumers to re-render on every streaming text chunk even though the active session set rarely changes mid-stream. Use functional updaters with identity checks: return the same Set reference when content is identical to skip unnecessary state updates.