perf(chat): derive upstreamModelId from providerGroups to eliminate duplicate fetch#607
Closed
HUQIANTAO wants to merge 1 commit into
Closed
Conversation
…cate fetch useProviderModels already fetches /api/providers/models and returns providerGroups with upstreamModelId on every model row. A separate useEffect was making an identical network request solely to extract this field, adding unnecessary latency on every provider/model change. Replace the useEffect + useState + fetch with a useMemo that looks up the matching group and model from the already-available providerGroups, using the same findModelOption helper for canonical-id matching.
|
Someone is attempting to deploy a commit to the op7418's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Closing this PR as part of a batch of low-signal/bulk-generated submissions from the same account. Please open one focused PR with a clear problem statement, implementation rationale, and tests if this change is intentional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatViewwas making a duplicatefetch('/api/providers/models')inside auseEffectsolely to extractupstreamModelIdfor the context-window indicator — even thoughuseProviderModels(called 20 lines above) already fetches the same endpoint and returns the fullproviderGroupsarray withupstreamModelIdon every model row.Change
providerGroupsfrom the existinguseProviderModelscalluseState+useEffect+fetchwith auseMemothat derivescurrentModelUpstreamby scanningproviderGroupsin-memoryfindModelOptionhelper for canonical-id matching (preserves tech-debt 界面问题：发送的消息如果内容很长，没有限高，可以折叠内容或者限制高度滚动 #37 handling)Impact