Repository navigation
Conversation
ooniprobe and oonimeasurements are moving to reading the client's address from the X-Forwarded-For entry our proxy appends (ooni/backend client_ip_from_proxy). The legacy API host, backend-fsn, forwards many of their paths to the ALB, appending the client's address before the ALB appends backend-fsn's. Per its live nginx config (nginx -T, 2026-10-04; the ooni-backend role's template is out of date): - to ooniprobe: login/register/update, /report, check-in, manifest/sign_credential/submit_measurement, test-list/tor-targets and psiphon-config; - to oonimeasurements: measurements, raw_measurement, measurement_meta, aggregation, observations, analysis. Each sets X-Forwarded-For $proxy_add_x_forwarded_for, and the ALB routes each of these paths straight to its service, so the entry backend-fsn appends is the client's. TRUSTED_PROXIES lists backend-fsn's address, from its Route 53 record, for both services. Without it ooniprobe would geolocate every probe using api.ooni.io to backend-fsn, and oonimeasurements would put every client it forwards in one rate limit. Settings ignore unknown variables, so this can be applied before the backend change is deployed, and must be by then.
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @hellais |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Thu, 08 Oct 2026 14:56:02 GMT |
hellais
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive headers using features from environment variables