Skip to content

refactor(core): 1.0.0-alpha#41

Draft
ElijahKotyluk wants to merge 42 commits intomasterfrom
refactor/core-v1-alpha
Draft

refactor(core): 1.0.0-alpha#41
ElijahKotyluk wants to merge 42 commits intomasterfrom
refactor/core-v1-alpha

Conversation

@ElijahKotyluk
Copy link
Copy Markdown
Member

@ElijahKotyluk ElijahKotyluk commented Apr 14, 2021

@onyx/core package rewrite for alpha release

@ElijahKotyluk ElijahKotyluk requested a review from dsseng April 14, 2021 07:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2021

Codecov Report

Merging #41 (7e794f5) into master (09b4ce5) will increase coverage by 2.08%.
The diff coverage is n/a.

❗ Current head 7e794f5 differs from pull request most recent head 403cd68. Consider uploading reports for the commit 403cd68 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master       #41      +/-   ##
===========================================
+ Coverage   97.91%   100.00%   +2.08%     
===========================================
  Files          27         1      -26     
  Lines         383        26     -357     
  Branches       69         7      -62     
===========================================
- Hits          375        26     -349     
+ Misses          7         0       -7     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
packages/core/src/result.ts 100.00% <0.00%> (ø)
packages/core/src/hooks.ts
packages/matchers/src/toThrow.ts
packages/matchers/src/toBeTypeOf.ts
packages/matchers/src/toBeDefined.ts
packages/matchers/src/toHaveLength.ts
packages/core/src/interface.ts
packages/matchers/src/toBeNull.ts
packages/matchers/src/matchers.ts
packages/matchers/src/toBeNaN.ts
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6264b16...403cd68. Read the comment docs.

@ElijahKotyluk ElijahKotyluk added the work in progress A work in progress label Apr 14, 2021
import { Status } from '../src/result'
import Runnable from '../src/runnable'
import Runner, { normalizeRunOptions, RunOptions } from '../src/runner'
//import { Status } from '../src/result'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it all commented out?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am rethinking the Runner class entirely. I am aiming for generator + co-routines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress A work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants