fix(worker-ops): preserve queue tracking and prevent scheduler recovery stalls#65
Draft
liobrasil wants to merge 3 commits intonavid/new-worker-archfrom
Draft
fix(worker-ops): preserve queue tracking and prevent scheduler recovery stalls#65liobrasil wants to merge 3 commits intonavid/new-worker-archfrom
liobrasil wants to merge 3 commits intonavid/new-worker-archfrom
Conversation
dbb5672 to
db29997
Compare
7ba7ee6 to
412dac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three worker-ops reliability issues in
FlowYieldVaultsEVMWorkerOps.Commit Breakdown
5350c4c— recover failed workers without scheduler stallsa5db0b3— retain tracked requests when fail-marking failsstopAll(): removesscheduledRequestsentries only ifmarkRequestAsFailed(...)succeeds._checkForFailedWorkerRequests(): keeps entries tracked when fail-marking fails, so recovery can retry instead of losing queue ownership.412dac2— keep tracking on request lookup failuresWorkerHandler.executeTransaction()now:markRequestAsFailed(...)with tracked request data;Why
Before these fixes, requests could remain
PROCESSINGon EVM while Cadence-side tracking was dropped, and scheduler recovery/capacity ordering could stall invalid/failing request handling.Scope
cadence/contracts/FlowYieldVaultsEVMWorkerOps.cdc