Open
Conversation
ci: keep single Claude review comment
Claude was using `gh api` instead of `gh pr comment` to post reviews, but `gh api` is not in the allowed tools list, causing the comment to fail silently. Changes: - Add explicit warning to use `gh pr comment` and not `gh api` - Clarify the command format with a proper code block Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
Claude was using `gh api` instead of `gh pr comment` to post reviews, but `gh api` is not in the allowed tools list, causing the comment to fail silently. Changes: - Add explicit warning to use `gh pr comment` and not `gh api` - Clarify the command format with a proper code block Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
holyfuchs
approved these changes
Feb 19, 2026
liobrasil
reviewed
Feb 19, 2026
liobrasil
reviewed
Feb 20, 2026
…-requests-and-docs
…ts-and-docs fix(stopAll): fail canceled worker requests + docs cleanup
077a42c to
81a66c6
Compare
7519e89 to
c6e349f
Compare
…commit ci(worker): guard strategy selection in Worker Operations CI
…ultsEVM into navid/new-worker-arch
dbb5672 to
db29997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Dual-Worker Architecture
✅ Issues Resolved
📋 Summary
This PR migrates the FlowYieldVaultsEVM worker design from a single interval-based worker that processed one request at a time to a dual-worker architecture. The new system enables parallel processing of multiple requests with automatic scheduling and crash recovery.
🔄 What Changed
Before
After
maxProcessingRequests(default: 3) requests processed concurrently✨ New Features
maxProcessingRequests)maxProcessingRequests: 3)🏗️ Architecture Changes
Before: Single Worker
After: Dual-Worker System
Request Processing Flow:
FlowYieldVaultsRequestsescrows funds (status: PENDING)maxProcessingRequests - current_in_flightpreprocessRequests()to validate and transition PENDING → PROCESSINGprocessRequest()completeProcessing()to mark COMPLETED/FAILED on EVMscheduledRequeststracking🧪 Testing
New Test Suite:
run_worker_tests.shComprehensive E2E tests covering:
maxProcessingRequestsrespected)Run Tests:
./local/setup_and_run_emulator.sh && ./local/deploy_full_stack.sh ./local/run_worker_tests.sh./local/run_worker_tests.sh.📖 Documentation Updates